Skip to content

travis-ci integration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

travis-ci integration #1

wants to merge 15 commits into from

Conversation

GabLeRoux
Copy link

@GabLeRoux GabLeRoux commented Jan 24, 2018 •
edited
Loading

👋 Hey there,
I tried to use this library, your fork doesn't allow writing issue, I think your fork is more up to date and maintained so I didn't create an issue upstream. Anyway, here's a pr that brings travis-ci testing for multiple python versions. It will run both offline and live tests and I made sure credentials are encrypted (confirmed working).

I tried to run the tests, but they're all failing with the same error message:

ERROR: test_api_client_instance_created (tests.tests_live.TogglClientApiLiveTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/tests/tests_live.py", line 16, in setUp
    self.api = TogglClientApi(self.settings)
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/toggl/api_client.py", line 30, in __init__
    self.user_agent = self.credentials['user_agent']
KeyError: 'user_agent'

So there's probably something wrong. I did not look at the tests yet, I can't tell right now if it's something that changed recently that broke the tests or if the tests are just broken.

You can find the full output here:
https://travis-ci.org/GabLeRoux/toggl-python-api-client/builds/332608834

btw: I know there are many commits, took me a few attempts until I manage to get this working in travis, I can create a new pr and squash everything into one commit if you prefer ;)

Instructions for travis encrytped env variables

documentation

gem install travis
travis encrypt \
WORKSPACE_NAME=example-workspace \
TOKEN=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx \
WORKSPACE_ID=yyyyyyy \
USER_ID=zzzzzzz \
--add env.matrix

@GabLeRoux
ran travis init for python
7b1ace1
@GabLeRoux
Add test requirement in install key
61c7438
@GabLeRoux
run actual command for travis requirements
c894021
@GabLeRoux
running tests/tests_offline.py travis test (will fail on python3)
cda1aa6
@GabLeRoux
run python setup.py -q install in installation step
60998a9
@GabLeRoux
WIP: python -m unittest discover for travis + versions and tests/test…
9d3e288 
…s_live_config.json file generation
@GabLeRoux
fix tests/tests_live_config.json: No such file or directory
43e15c0
@GabLeRoux
fix tests/tests_live_config.json: No such file or directory (yaml esc…
9b80743 
…aping problem)
@GabLeRoux
fix tests_live_config.json location
74502d4
@GabLeRoux
Add test account to travis encrypted values
2748a68
@GabLeRoux
Remove todo (done in previous commit)
25a440d
@GabLeRoux
Properly encrypted env variables using travis encrypt --add end.matrix
6ea148d
@GabLeRoux
travis env variable in same secure env.matrix
77d8d16
@GabLeRoux
travis secret all in same matrix
06d6307 
travis encrypt \
WORKSPACE_NAME=example-workspace \
TOKEN=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx \
WORKSPACE_ID=yyyyyyy \
USER_ID=zzzzzzz \
--add env.matrix
@GabLeRoux
specify a default user_agent to fix a few online tests
6716acd
@GabLeRoux
Copy link
Author

GabLeRoux commented Jan 24, 2018 •
edited
Loading

I've specified a default user_agent (python), and now a few tests pass.

https://travis-ci.org/GabLeRoux/toggl-python-api-client/builds/332614236

On python2.7 Most of the tests fail with workspace_id:

Traceback (most recent call last):
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/tests/tests_offline.py", line 25, in setUp
    self.api = TogglClientApi(self.settings)
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/toggl/api_client.py", line 32, in __init__
    self.workspace_id = int(self.credentials['workspace_id'])
KeyError: 'workspace_id'

and there's one test failing with this:

FAIL: test_api_toggl_get_member_total_hours_range_response_ok (tests.tests_live.TogglClientApiLiveTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/tests/tests_live.py", line 58, in test_api_toggl_get_member_total_hours_range_response_ok
    self.assertGreater(total, 0)
AssertionError: 0 not greater than 0

The tests seem to fail on 3.3 and above, all tests are failing with this:

Traceback (most recent call last):
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/tests/tests_live.py", line 16, in setUp
    self.api = TogglClientApi(self.settings)
  File "/home/travis/build/GabLeRoux/toggl-python-api-client/toggl/api_client.py", line 25, in __init__
    self.credentials = dict(self.defaultCredentials.items() + credentials.items())
TypeError: unsupported operand type(s) for +: 'dict_items' and 'dict_items'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@GabLeRoux